linux-kernel - Re: [PATCH][next] xattr: remove redundant check on variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241031154314.576ksnwaruuqqwq2@quack3>
Date: Thu, 31 Oct 2024 16:43:14 +0100
From: Jan Kara <jack@...e.cz>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] xattr: remove redundant check on variable err

On Wed 30-10-24 18:01:40, Colin Ian King wrote:
> Curretly in function generic_listxattr the for_each_xattr_handler loop
> checks err and will return out of the function if err is non-zero.
> It's impossible for err to be non-zero at the end of the function where
> err is checked again for a non-zero value. The final non-zero check is
> therefore redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Yeah, makes sense. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/xattr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xattr.c b/fs/xattr.c
> index 05ec7e7d9e87..21beb82ab5dc 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -1015,7 +1015,7 @@ generic_listxattr(struct dentry *dentry, char *buffer, size_t buffer_size)
>  			return err;
>  	}
>  
> -	return err ? err : buffer_size - remaining_size;
> +	return buffer_size - remaining_size;
>  }
>  EXPORT_SYMBOL(generic_listxattr);
>  
> -- 
> 2.39.5
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR