linux-kernel - Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241030205535.7ea507ea@akair>
Date: Wed, 30 Oct 2024 20:55:35 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Mithil Bavishi <bavishimithil@...il.com>
Cc: Aaro Koskinen <aaro.koskinen@....fi>, Kevin Hilman
 <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Tony Lindgren
 <tony@...mide.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung
 Galaxy Tab 2 series

Hi,

a quick first pass of review.

Am Wed, 30 Oct 2024 19:41:32 +0000
schrieb Mithil Bavishi <bavishimithil@...il.com>:

> Create common device tree for Samsung Espresso series devices
> 
> Differentiate based on screen sizes, panels, touch controllers,
> and batteries
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@...il.com>
> ---
[...]

> +	backlight_pins: pinmux_backlight_pins {

- instead of _ in node names please, also for other places:
    backlight_pins: pinmux-backlight-pins

[...]
> +
> +#include "twl6030.dtsi"
> +
really??? you include both twl6030 and twl6032. That does not make any
sense. Including twl6030_omap4.dtsi might make sense but not
twl6030.dtsi.

Regards,
Andreas