linux-kernel - Re: [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241030213713.45223f64@akair>
Date: Wed, 30 Oct 2024 21:37:13 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Mithil Bavishi <bavishimithil@...il.com>
Cc: Aaro Koskinen <aaro.koskinen@....fi>, Kevin Hilman
 <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Tony Lindgren
 <tony@...mide.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2
 7.0

Am Wed, 30 Oct 2024 19:41:34 +0000
schrieb Mithil Bavishi <bavishimithil@...il.com>:

> Create a device tree for the 3 inch variants (P3100, P3110, P3113)
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@...il.com>
> ---
>  arch/arm/boot/dts/ti/omap/Makefile            |  1 +
>  .../dts/ti/omap/omap4-samsung-espresso7.dts   | 70
> +++++++++++++++++++ 2 files changed, 71 insertions(+)
>  create mode 100644
> arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> 
  DTC     arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb
arch/arm/boot/dts/ti/omap/twl6032.dtsi:67.37-70.4: ERROR
(phandle_references):
/ocp/interconnect@...00000/segment@...arget-module@...00/i2c@...wl@...usb-comparator:
Reference to non-existent node or label "ldosb"

  also defined at arch/arm/boot/dts/ti/omap/twl6030.dtsi:83.37-86.4
  also defined at
  arch/arm/boot/dts/ti/omap/omap4-samsung-espresso-common.dtsi:616.21-618.3
  ERROR: Input tree has errors, aborting (use -f to force output)

I think you accidently submitted a wrong/outdated version. You had
removed the twl6030.dtsi include in pmOS after I pointed that out to
you in an issue there. Any further review is futile.

From:
https://gitlab.com/postmarketOS/pmaports/-/issues/2825:
>Mighty
>@MightyM17
>· 4 months ago
>Reporter
>Oh, there's a hanging include "twl6030.dtsi" thats causing us trouble,
>I'll port the usb regs and comparator to twl6032.dtsi and it should
>work fine.

that is a clear sign that somehow an old version seems to pop up.

Regards,
Andreas