[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7c993178-c021-43d2-a10f-710d7cb3a615@kernel.org>
Date: Wed, 30 Oct 2024 07:10:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ming-Jen Chen <mjchen0829@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
mjchen@...oton.com, peng.fan@....com, sudeep.holla@....com, arnd@...db.de,
conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org,
dmitry.torokhov@...il.com
Subject: Re: [PATCH 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad
On 30/10/2024 02:46, Ming-Jen Chen wrote:
>> Description of these properties did not tell me much about their purpose
>> and underlying hardware, so I don't know which fits here. It looks like
>> you want to configure clock... but then wording confuses me -
>> "per-scale". What is "per"? Isn't it usually "pre"?
>>
>> So in general I don't know what to recommend you because your patch is
>> really unclear.
>>
>> Please also wrap emails according to mailing lists standards. And use
>> proper line separation of sentences. It's really hard to understand your
>> email.
>
> I apologize for any confusion caused by my previous responses regarding
> this issue.
> It seems that our discussion has reached a bit of a bottleneck.
>
> I have a suggestion that I hope you might agree with: I would like to
> upload version 2 of the code.
> In this version, I will rewrite the properties, although it may not
> resolve their underlying issues.
> I will also continue to keep our current discussion ongoing in version 2.
>
> Thank you for your understanding, and I look forward to your thoughts on
> this approach
Sure, let's try that.
Best regards,
Krzysztof
Powered by blists - more mailing lists