[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3035aa2e-dbab-4224-a5db-d18e37003d5e@kernel.org>
Date: Wed, 30 Oct 2024 12:17:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>,
Santosh Shilimkar <ssantosh@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>
Cc: linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Herve Codina <herve.codina@...tlin.com>,
Christopher Cordahi <christophercordahi@...ometrics.ca>
Subject: Re: [PATCH 4/5] mtd: rawnand: davinci: Add clock resource
On 30/10/2024 11:47, Bastien Curutchet wrote:
> NAND controller has a reference clock but the driver doesn't use it.
>
> Add a struct clock in the struct davinci_nand_info so it can be used
> to compute timings.
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>
> ---
> drivers/mtd/nand/raw/davinci_nand.c | 9 +++++++++
Where are the bindings?
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
> index 3c0efbdd789e..11dc30c29957 100644
> --- a/drivers/mtd/nand/raw/davinci_nand.c
> +++ b/drivers/mtd/nand/raw/davinci_nand.c
> @@ -10,6 +10,7 @@
> * Dirk Behme <Dirk.Behme@...il.com>
> */
>
> +#include <linux/clk.h>
> #include <linux/err.h>
> #include <linux/iopoll.h>
> #include <linux/kernel.h>
> @@ -117,6 +118,8 @@ struct davinci_nand_info {
> uint32_t mask_cle;
>
> uint32_t core_chipsel;
> +
> + struct clk *clk;
> };
>
> static DEFINE_SPINLOCK(davinci_nand_lock);
> @@ -822,6 +825,12 @@ static int nand_davinci_probe(struct platform_device *pdev)
> return -EADDRNOTAVAIL;
> }
>
> + info->clk = devm_clk_get(&pdev->dev, "aemif");
> + if (IS_ERR(info->clk)) {
> + dev_err(&pdev->dev, "failed to get clock %ld", PTR_ERR(info->clk));
Syntax is return dev_err_probe.
Best regards,
Krzysztof
Powered by blists - more mailing lists