linux-kernel - Re: [PATCH v2] drm: xlnx: zynqmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b2b636e-f361-457e-8d19-9be6c237ef66@ideasonboard.com>
Date: Wed, 30 Oct 2024 14:26:21 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Steffen Dirkwinkel <lists@...ffen.cc>, dri-devel@...ts.freedesktop.org,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, stable@...r.kernel.org,
 Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Michal Simek <michal.simek@....com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection

Hi,

On 28/10/2024 15:42, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
> 
> drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
> zynqmp_dpsub_kms_init creates the connector and without it we don't
> enable hotplug detection.
> 
> Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge")
> Cc: stable@...r.kernel.org
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
> ---
>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index bd1368df7870..311397cee5ca 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
>   	if (ret)
>   		return ret;
>   
> -	drm_kms_helper_poll_init(drm);
> -
>   	ret = zynqmp_dpsub_kms_init(dpsub);
>   	if (ret < 0)
>   		goto err_poll_fini;
>   
> +	drm_kms_helper_poll_init(drm);
> +
>   	/* Reset all components and register the DRM device. */
>   	drm_mode_config_reset(drm);
>   

Thanks, will apply to drm-misc-next.

Btw, don't send a fixed version with the same version number as the last 
one. Tools get confused...

  Tomi