lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ba258236-cf0e-40dc-bab1-4c06ee989824@ideasonboard.com>
Date: Wed, 30 Oct 2024 14:26:46 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Steffen Dirkwinkel <lists@...ffen.cc>, dri-devel@...ts.freedesktop.org,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Anatoliy Klymenko <anatoliy.klymenko@....com>
Cc: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Michal Simek <michal.simek@....com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm: xlnx: zynqmp_disp: layer may be null while
 releasing

Hi,

On 28/10/2024 15:39, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
> 
> layer->info can be null if we have an error on the first layer in
> zynqmp_disp_create_layers
> 
> Fixes: 1836fd5ed98d ("drm: xlnx: zynqmp_dpsub: Minimize usage of global flag")
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
> ---
>   drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 9368acf56eaf..e4e0e299e8a7 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -1200,6 +1200,9 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp,
>   {
>   	unsigned int i;
>   
> +	if (!layer->info)
> +		return;
> +
>   	for (i = 0; i < layer->info->num_channels; i++) {
>   		struct zynqmp_disp_layer_dma *dma = &layer->dmas[i];
>   


Thanks, will apply to drm-misc-next.

  Tomi


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ