[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55719a66-aeb9-4c20-afa6-e46dbb54c22f@paulmck-laptop>
Date: Wed, 30 Oct 2024 06:46:45 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Jonas Oberhauser <jonas.oberhauser@...weicloud.com>
Cc: Boqun Feng <boqun.feng@...il.com>, stern@...land.harvard.edu,
parri.andrea@...il.com, will@...nel.org, peterz@...radead.org,
npiggin@...il.com, dhowells@...hat.com, j.alglave@....ac.uk,
luc.maranget@...ia.fr, akiyks@...il.com, dlustig@...dia.com,
joel@...lfernandes.org, urezki@...il.com, quic_neeraju@...cinc.com,
frederic@...nel.org, linux-kernel@...r.kernel.org,
lkmm@...ts.linux.dev, hernan.poncedeleon@...weicloud.com
Subject: Re: [PATCH v4 4/5] tools/memory-model: Switch to softcoded herd7 tags
On Wed, Oct 30, 2024 at 12:50:19PM +0100, Jonas Oberhauser wrote:
>
>
> Am 10/29/2024 um 1:04 AM schrieb Boqun Feng:
> >
> > One bit below:
> >
> > On Mon, Sep 30, 2024 at 12:57:09PM +0200, Jonas Oberhauser wrote:
> > > ------------------------------------------------------------------------------
> > > | RMW ops w/o return value | |
> > > ------------------------------------------------------------------------------
> > > - | atomic_add | R*[noreturn] ->rmw W*[once] |
> > > + | atomic_add | R*[noreturn] ->rmw W*[noreturn] |
> >
> > Not in this patch, but don't you need to update this again to all cap
> > to match your changes in patch #5? ;-)
> >
>
> Hmmm, probably that is a good idea.
> I actually had thought about it for some of the other places in the doc that
> mention the tags, and concluded that we'll just use the semantic tags there.
>
> But in fact, this file is about the syntactic representation in herd, and
> there is no noreturn semantic tag on the W*, so it wouldn't match it even if
> it were correct.
>
> So I think this needs to be addressed in 5/5.
Thank you for checking!
Please send me either a replacement for 5/5 or a patch for me to fold
into 5/5.
Thanx, Paul
Powered by blists - more mailing lists