[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0712919e-300f-4eef-aa3f-ad5533743296@kernel.org>
Date: Thu, 31 Oct 2024 16:47:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Csókás, Bence <csokas.bence@...lan.hu>,
dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: Mesih Kilinc <mesihkilinc@...il.com>, Chen-Yu Tsai <wens@...nel.org>,
Vinod Koul <vkoul@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>, Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v4 02/10] dma-engine: sun4i: Add has_reset option to quirk
On 31/10/2024 13:35, Csókás, Bence wrote:
> From: Mesih Kilinc <mesihkilinc@...il.com>
>
> Allwinner suniv F1C100s has a reset bit for DMA in CCU. Sun4i do not
> has this bit but in order to support suniv we need to add it. So add
> support for reset bit.
>
> Signed-off-by: Mesih Kilinc <mesihkilinc@...il.com>
> [ csokas.bence: Rebased and addressed comments ]
> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>
> ---
>
> Notes:
> Changes in v2:
> * Call reset_control_deassert() unconditionally, as it supports optional resets
> * Use dev_err_probe()
> * Whitespace
> Changes in v3:
> * More dev_err_probe() fixes
> Changes in v3:
> * Use return value of dev_err_probe()
>
> drivers/dma/sun4i-dma.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
> index d472f57a39ea..4626cc8ad114 100644
> --- a/drivers/dma/sun4i-dma.c
> +++ b/drivers/dma/sun4i-dma.c
> @@ -15,6 +15,7 @@
> #include <linux/of_dma.h>
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> +#include <linux/reset.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
>
> @@ -159,6 +160,7 @@ struct sun4i_dma_config {
> u8 ddma_drq_sdram;
>
> u8 max_burst;
> + bool has_reset;
> };
>
> struct sun4i_dma_pchan {
> @@ -208,6 +210,7 @@ struct sun4i_dma_dev {
> int irq;
> spinlock_t lock;
> const struct sun4i_dma_config *cfg;
> + struct reset_control *rst;
> };
>
> static struct sun4i_dma_dev *to_sun4i_dma_dev(struct dma_device *dev)
> @@ -1215,6 +1218,15 @@ static int sun4i_dma_probe(struct platform_device *pdev)
> return PTR_ERR(priv->clk);
> }
>
> + if (priv->cfg->has_reset) {
> + priv->rst = devm_reset_control_get_exclusive(&pdev->dev,
> + NULL);
Unnecessary wrapping.
> + if (IS_ERR(priv->rst)) {
Drop {}.
> + return dev_err_probe(&pdev->dev, PTR_ERR(priv->rst),
> + "Failed to get reset control\n");
And this should be aligned with opening (. Run checkpatch --strict.
> + }
> + }
> +
> platform_set_drvdata(pdev, priv);
> spin_lock_init(&priv->lock);
>
> @@ -1287,6 +1299,14 @@ static int sun4i_dma_probe(struct platform_device *pdev)
> return ret;
> }
>
> + /* Deassert the reset control */
> + ret = reset_control_deassert(priv->rst);
> + if (ret) {
> + dev_err_probe(&pdev->dev, ret,
> + "Failed to deassert the reset control\n");
Missing alignment.
Best regards,
Krzysztof
Powered by blists - more mailing lists