linux-kernel - Re: [PATCH v2] tracing: Replace strncpy() with strscpy() when copying comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031114838.02b404ba@gandalf.local.home>
Date: Thu, 31 Oct 2024 11:48:38 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Jinjie Ruan <ruanjinjie@...wei.com>, mhiramat@...nel.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tracing: Replace strncpy() with strscpy() when
 copying comm

On Thu, 31 Oct 2024 11:12:06 -0400
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1934,7 +1934,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> >   	max_data->critical_start = data->critical_start;
> >   	max_data->critical_end = data->critical_end;
> >   
> > -	strncpy(max_data->comm, tsk->comm, TASK_COMM_LEN);
> > +	strscpy(max_data->comm, tsk->comm);  
> 
> make allyesconfig + make please ?

Or at a minimum, make sure all the code you change is compiled.

-- Steve