linux-kernel - Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fcd4858d-244a-d491-7c22-4231a654ca81@igalia.com>
Date: Thu, 31 Oct 2024 13:00:16 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: "kvalo@...nel.org" <kvalo@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "kernel@...ccoli.net" <kernel@...ccoli.net>,
 "kernel-dev@...lia.com" <kernel-dev@...lia.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
 "rtl8821cerfe2@...il.com" <rtl8821cerfe2@...il.com>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 "syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com"
 <syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com>
Subject: Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read
 efuse in case of failures

On 30/10/2024 23:15, Ping-Ke Shih wrote:
> 
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> index 82cf5fb5175f..f741066c06de 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> @@ -164,7 +164,17 @@ void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
>>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>>         u32 value32;
>>         u8 readbyte;
>> -       u16 retry;
>> +       u16 retry, max_attempts;
>> +
> 
> Declarations should be in reverse X'mas tree order.
> Just add max_attempts to a new line at proper position. 

Thanks, V3 just sent:
https://lore.kernel.org/r/20241031155731.1253259-1-gpiccoli@igalia.com/