linux-kernel - Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d9471f600224d23bb1f49a8ed4943c2@realtek.com>
Date: Thu, 31 Oct 2024 02:15:38 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC: "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel@...ccoli.net" <kernel@...ccoli.net>,
        "kernel-dev@...lia.com" <kernel-dev@...lia.com>,
        "rtl8821cerfe2@...il.com"
	<rtl8821cerfe2@...il.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com"
	<syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com>
Subject: Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures


> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
> index 82cf5fb5175f..f741066c06de 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
> @@ -164,7 +164,17 @@ void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>         u32 value32;
>         u8 readbyte;
> -       u16 retry;
> +       u16 retry, max_attempts;
> +

Declarations should be in reverse X'mas tree order.
Just add max_attempts to a new line at proper position.