linux-kernel - Re: [PATCH v3 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jt5d3473zg34yhgykgqftlvk6fqekankuyjj57uxl56sqa3xvm@nvfv7kwtcwex>
Date: Thu, 31 Oct 2024 18:51:13 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: loic.poulain@...aro.org, rfoss@...nel.org, andi.shyti@...nel.org, 
	linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v3 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

On Thu, Oct 31, 2024 at 05:53:39PM +0800, Jiapeng Chong wrote:
> Variable cci_clk_rate is not effectively used, so delete it.
> 
> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
> Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> Changes in v3:
>   -Modify the commit message.

Modify how?
What was the reason for ignoring the R-B tag?

> 
>  drivers/i2c/busses/i2c-qcom-cci.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
> index 5cc791b3b57d..a0ef43e99751 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -523,7 +523,6 @@ static const struct dev_pm_ops qcom_cci_pm = {
>  static int cci_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	unsigned long cci_clk_rate = 0;
>  	struct device_node *child;
>  	struct resource *r;
>  	struct cci *cci;
> @@ -594,14 +593,6 @@ static int cci_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n");
>  	cci->nclocks = ret;
>  
> -	/* Retrieve CCI clock rate */
> -	for (i = 0; i < cci->nclocks; i++) {
> -		if (!strcmp(cci->clocks[i].id, "cci")) {
> -			cci_clk_rate = clk_get_rate(cci->clocks[i].clk);
> -			break;
> -		}
> -	}
> -
>  	ret = cci_enable_clocks(cci);
>  	if (ret < 0)
>  		return ret;
> -- 
> 2.32.0.3.g01195cf9f
> 

-- 
With best wishes
Dmitry