linux-kernel - Re: [PATCH v3 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ywuvj7wpchcjktc6sxjmiitxv225qzg3cvxt5bwrx5wurabqhj@r23pyeg53z3j>
Date: Thu, 31 Oct 2024 23:02:31 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, 
	loic.poulain@...aro.org, rfoss@...nel.org, linux-i2c@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v3 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

Hi Dmitry,

On Thu, Oct 31, 2024 at 06:51:13PM +0200, Dmitry Baryshkov wrote:
> On Thu, Oct 31, 2024 at 05:53:39PM +0800, Jiapeng Chong wrote:
> > Variable cci_clk_rate is not effectively used, so delete it.
> > 
> > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
> > Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate")
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > ---
> > Changes in v3:
> >   -Modify the commit message.
> 
> Modify how?
> What was the reason for ignoring the R-B tag?

This patch has already been taken and I have added the R-B's as
they were given.

However, Jiapeng, please, next time try to be a bit more specific
with the changelog, consider that people really read it.

Andi