linux-kernel - Re: [PATCH v2 2/2] media: i2c: imx415: Drop HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02802b4a-af44-45ef-892d-870423fc8a38@wolfvision.net>
Date: Thu, 31 Oct 2024 22:38:35 +0100
From: Michael Riesch <michael.riesch@...fvision.net>
To: Tommaso Merciai <tomm.merciai@...il.com>
Cc: sakari.ailus@...ux.intel.com, laurent.pinchart@...asonboard.com,
 Martin Hecht <martin.hecht@...et.eu>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Sebastian Reichel <sre@...nel.org>, Zhi Mao <zhi.mao@...iatek.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Julien Massot <julien.massot@...labora.com>,
 Bingbu Cao <bingbu.cao@...el.com>,
 Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Nicholas Roth <nicholas@...hemail.net>,
 Paul Elder <paul.elder@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] media: i2c: imx415: Drop HAS_EVENTS flag

Hi all,

Sorry for the recent HTML mail. Let's try again -- hopefully it works now.

On 10/29/24 23:56, Tommaso Merciai wrote:
> v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a
> control handler is set. Let's drop the HAS_EVENTS flag.
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Signed-off-by: Tommaso Merciai <tomm.merciai@...il.com>

Thanks for the patch.

Acked-by: Michael Riesch <michael.riesch@...fvision.net>

Best regards,
Michael

> ---
>  drivers/media/i2c/imx415.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index a20b0db330d3..3f7924aa1bd3 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1113,8 +1113,7 @@ static int imx415_subdev_init(struct imx415 *sensor)
>  	if (ret)
>  		return ret;
>  
> -	sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> -				V4L2_SUBDEV_FL_HAS_EVENTS;
> +	sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
>  	sensor->pad.flags = MEDIA_PAD_FL_SOURCE;
>  	sensor->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR;
>  	ret = media_entity_pads_init(&sensor->subdev.entity, 1, &sensor->pad);