linux-kernel - Re: [PATCH v2 2/2] clocksource/drivers/timer-ti-dm: automate device_node cleanup in dmtimer_percpu_quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05ffb173-1a1b-48ea-997f-2f4816dd3f61@kernel.org>
Date: Thu, 31 Oct 2024 12:09:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Tony Lindgren <tony@...mide.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] clocksource/drivers/timer-ti-dm: automate
 device_node cleanup in dmtimer_percpu_quirk_init()

On 28/10/2024 18:06, Javier Carrasco wrote:
> Simplify the code and make it more robust by automating the node release
> when it goes out of scope.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/clocksource/timer-ti-dm-systimer.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
> index 23be1d21ce21..d1c144d6f328 100644
> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -686,15 +686,13 @@ subsys_initcall(dmtimer_percpu_timer_startup);
>  
>  static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa)
>  {
> -	struct device_node *arm_timer;
> +	struct device_node *arm_timer __free(device_node) =
> +		of_find_compatible_node(NULL, NULL, "arm,armv7-timer");
>  
> -	arm_timer = of_find_compatible_node(NULL, NULL, "arm,armv7-timer");
>  	if (of_device_is_available(arm_timer)) {
>  		pr_warn_once("ARM architected timer wrap issue i940 detected\n");
> -		of_node_put(arm_timer);


You just added this. Don't add code which is immediately removed. It's a
noop or wrong code.

Best regards,
Krzysztof