linux-kernel - Re: [PATCH 2/2] Bluetooth: btbcm: automate node cleanup in btbcm_get_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aab34ae4-0f6b-4720-b14e-69add0355daa@kernel.org>
Date: Thu, 31 Oct 2024 12:08:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: btbcm: automate node cleanup in
 btbcm_get_board_name()

On 30/10/2024 16:46, Javier Carrasco wrote:
> Switch to a more robust approach by automating the node release when it
> goes out of scope, removing the need for explicit calls to
> of_node_put().
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/bluetooth/btbcm.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 400c2663d6b0..a1153ada74d2 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -541,23 +541,19 @@ static const struct bcm_subver_table bcm_usb_subver_table[] = {
>  static const char *btbcm_get_board_name(struct device *dev)
>  {
>  #ifdef CONFIG_OF
> -	struct device_node *root;
> +	struct device_node *root __free(device_node) = of_find_node_by_path("/");
>  	char *board_type;
>  	const char *tmp;
>  
> -	root = of_find_node_by_path("/");
>  	if (!root)
>  		return NULL;
>  
> -	if (of_property_read_string_index(root, "compatible", 0, &tmp)) {
> -		of_node_put(root);

You just added this. Don't add code which is immediately removed. It's a
noop or wrong code.



Best regards,
Krzysztof