linux-kernel - Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f06dea2e-893b-4de5-89a3-e25af56afb31@linaro.org>
Date: Thu, 31 Oct 2024 13:13:24 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Andi Shyti <andi.shyti@...nel.org>,
 Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: loic.poulain@...aro.org, rfoss@...nel.org, linux-i2c@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

Hi Andi,

On 10/31/24 12:44, Andi Shyti wrote:
> Hi Jiapeng,
> 
> On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote:
>> Variable ret is not effectively used, so delete it.
>>
>> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> thanks for your patch! Applied to i2c/i2c-host
> 
> Thanks,
> Andi
> 

FWIW I've noticed that my Reviewed-by tag was added to the accepted change,
while it was the conditional one... Actually I don't know how to be aware
of such nuances, if only b4 tool is used, likely there is no way for it.

Hopefully I'm not too picky with it.

--
Best wishes,
Vladimir