linux-kernel - Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1c55403-55ee-4742-b7e6-8f0a4387ce9e@linaro.org>
Date: Thu, 31 Oct 2024 13:59:45 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, loic.poulain@...aro.org,
 rfoss@...nel.org, linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

Hi Andi,

On 10/31/24 13:41, Andi Shyti wrote:
> Hi Vladimir,
> 
> On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote:
>> Hi Andi,
>>
>> On 10/31/24 12:44, Andi Shyti wrote:
>>> Hi Jiapeng,
>>>
>>> On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote:
>>>> Variable ret is not effectively used, so delete it.
>>>>
>>>> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
>>>>
>>>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>>>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
>>>> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>>>
>>> thanks for your patch! Applied to i2c/i2c-host
>>>
>>> Thanks,
>>> Andi
>>>
>>
>> FWIW I've noticed that my Reviewed-by tag was added to the accepted change,
>> while it was the conditional one... Actually I don't know how to be aware
>> of such nuances, if only b4 tool is used, likely there is no way for it.
> 
> I thought the change that made your r-b conditional was the
> Fixes tag, right? That is added. Have I missed anything?

ah, no, it was about the copy-pasted commit message, which mentions a much
more popular 'ret' local variable.

> (I noticed later the v3, but it's basically identical to the one
> I pushed).
> 

Well, I believe my concern about a commit message has quite low significance,
so let it be kept as is, the most essential code change part is untouched.

>> Hopefully I'm not too picky with it.
> 
> Absolutely not! Please, keep pinging me if you see anything I
> might have missed.

Thank you!

--
Best wishes,
Vladmir