linux-kernel - Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable cci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <auvqypvayvlhzi6n6jp3r6swq4sik3jvcxxafvu67i2y3r337m@uy33er3gujk2>
Date: Thu, 31 Oct 2024 13:23:46 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, 
	loic.poulain@...aro.org, rfoss@...nel.org, linux-i2c@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 -next] i2c: qcom-cci: Remove the unused variable
 cci_clk_rate

Hi Vladimir,

On Thu, Oct 31, 2024 at 01:59:45PM +0200, Vladimir Zapolskiy wrote:
> On 10/31/24 13:41, Andi Shyti wrote:
> > On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote:
> > > On 10/31/24 12:44, Andi Shyti wrote:
> > > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote:
> > > > > Variable ret is not effectively used, so delete it.
> > > > > 
> > > > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used.
> > > > > 
> > > > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532
> > > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > > > 
> > > > thanks for your patch! Applied to i2c/i2c-host
> > > > 
> > > > Thanks,
> > > > Andi
> > > > 
> > > 
> > > FWIW I've noticed that my Reviewed-by tag was added to the accepted change,
> > > while it was the conditional one... Actually I don't know how to be aware
> > > of such nuances, if only b4 tool is used, likely there is no way for it.
> > 
> > I thought the change that made your r-b conditional was the
> > Fixes tag, right? That is added. Have I missed anything?
> 
> ah, no, it was about the copy-pasted commit message, which mentions a much
> more popular 'ret' local variable.

oh yes, the new commit message says:

"Variable cci_clk_rate is not effectively used, so delete it."

I'm sorry, I will fix it.

Thanks,
Andi