linux-kernel - Re: [PATCH 38/44] drm/xe/oa: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ak3xx3vykmyutpanofmtj43hgv5vx3k35dxfxec4s53logdk22@qq67qukpkdga>
Date: Thu, 31 Oct 2024 08:12:50 -0500
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Nam Cao <namcao@...utronix.de>
CC: Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
	<frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Andreas Hindborg
	<a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda
	<ojeda@...nel.org>, Kees Cook <kees@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 38/44] drm/xe/oa: Switch to use hrtimer_setup()

On Mon, Oct 28, 2024 at 08:35:14AM +0100, Nam Cao wrote:
>There is a newly introduced hrtimer_setup() which will replace
>hrtimer_init(). This new function is similar to the old one, except that it
>also sanity-checks and initializes the timer's callback function.
>
>Switch to use this new function.
>
>Patch was created by using Coccinelle.
>
>Signed-off-by: Nam Cao <namcao@...utronix.de>


Acked-by: Lucas De Marchi <lucas.demarchi@...el.com>

Lucas De Marchi

>---
>Cc: Lucas De Marchi <lucas.demarchi@...el.com>
>---
> drivers/gpu/drm/xe/xe_oa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
>index eae38a49ee8e..600eaaee8a72 100644
>--- a/drivers/gpu/drm/xe/xe_oa.c
>+++ b/drivers/gpu/drm/xe/xe_oa.c
>@@ -1437,8 +1437,8 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream,
>
> 	WRITE_ONCE(u->exclusive_stream, stream);
>
>-	hrtimer_init(&stream->poll_check_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>-	stream->poll_check_timer.function = xe_oa_poll_check_timer_cb;
>+	hrtimer_setup(&stream->poll_check_timer, xe_oa_poll_check_timer_cb, CLOCK_MONOTONIC,
>+		      HRTIMER_MODE_REL);
> 	init_waitqueue_head(&stream->poll_wq);
>
> 	spin_lock_init(&stream->oa_buffer.ptr_lock);
>-- 
>2.39.5
>