linux-kernel - Re: [PATCH v6 04/13] iommufd: Verify object in iommufd_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031131311.GI10193@nvidia.com>
Date: Thu, 31 Oct 2024 10:13:11 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, corbet@....net, joro@...tes.org,
	suravee.suthikulpanit@....com, will@...nel.org,
	robin.murphy@....com, dwmw2@...radead.org, shuah@...nel.org,
	iommu@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	baolu.lu@...ux.intel.com, eric.auger@...hat.com,
	jean-philippe@...aro.org, mdf@...nel.org, mshavit@...gle.com,
	shameerali.kolothum.thodi@...wei.com, smostafa@...gle.com,
	yi.l.liu@...el.com, aik@....com, zhangfei.gao@...aro.org,
	patches@...ts.linux.dev
Subject: Re: [PATCH v6 04/13] iommufd: Verify object in
 iommufd_object_finalize/abort()

On Wed, Oct 30, 2024 at 02:34:30PM -0700, Nicolin Chen wrote:
> To support driver-allocated vIOMMU objects, it's required for IOMMU driver
> to call the provided iommufd_viommu_alloc helper to embed the core struct.
> However, there is no guarantee that every driver will call it and allocate
> objects properly.
> 
> Make the iommufd_object_finalize/abort functions more robust to verify if
> the xarray slot indexed by the input obj->id is having an XA_ZERO_ENTRY,
> which is the reserved value stored by xa_alloc via iommufd_object_alloc.
> 
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/iommufd/main.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason