linux-kernel - Re: [PATCH v2 1/1] platform/x86: intel: Add 'intel' prefix to the modules automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77eaee7a-4544-01e1-44b9-9173e670679f@linux.intel.com>
Date: Thu, 31 Oct 2024 16:39:53 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Masahiro Yamada <masahiroy@...nel.org>, 
    Tero Kristo <tero.kristo@...ux.intel.com>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    linux-kbuild@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>, 
    David Gow <davidgow@...gle.com>
Subject: Re: [PATCH v2 1/1] platform/x86: intel: Add 'intel' prefix to the
 modules automatically

On Mon, 28 Oct 2024, Andy Shevchenko wrote:

> On Mon, Oct 28, 2024 at 01:49:52PM +0100, Masahiro Yamada wrote:
> > On Mon, Oct 28, 2024 at 11:58 AM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > > On Wed, Oct 16, 2024 at 01:59:51PM +0300, Andy Shevchenko wrote:
> > > > Rework Makefile to add 'intel' prefix to the modules automatically.
> > > > This removes a lot of boilerplate code in it and also makes robust
> > > > against mistypos in the prefix.
> > >
> > > > ---
> > > >
> > > > v2: fixed obvious typos (LKP), Cc'ed to Kbuild ML (Ilpo), dropped RFC marker
> > > >
> > > > Note to Kbuild people: TBH I rather want to have something like this
> > > > to be available on the level of Kbuild for any of the subdirectories
> > > > in question.
> > >
> > > Anyone, any comments on this?
> > > This already passed a CI tests without failure so far. Perhaps it's good
> > > to apply to show the demand of such a feature in Kbuild in the future?
> > > Because I want to do the same for various */tests/ folders where we have
> > > tons of test*, *kunit modules effectively duplicating the folder name.
> > 
> > I do not like what you are doing here,
> 
> That's why the question is to Kbuild if it's possible to have this feature
> available treewide for users in a form that you like?
> 
> > but it is up to you whatever you do in Makefiles you maintain.
> 
> Thanks! Ilpo, what do you think about applying this in its current form?

I applied this patch now to review-ilpo branch. Hopefully we'll one day 
have a generic mechanism for this but until then this will have to do.

-- 
 i.