linux-kernel - Re: [PATCH v5 2/3] x86: probe memory block size advisement value during mm init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241101164801.GDZyUGQbe6g4FqtPf6@fat_crate.local>
Date: Fri, 1 Nov 2024 17:48:01 +0100
From: Borislav Petkov <bp@...en8.de>
To: Gregory Price <gourry@...rry.net>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-mm@...ck.org,
	linux-cxl@...r.kernel.org, Jonathan.Cameron@...wei.com,
	dan.j.williams@...el.com, rrichter@....com, Terry.Bowman@....com,
	dave.jiang@...el.com, ira.weiny@...el.com,
	alison.schofield@...el.com, dave.hansen@...ux.intel.com,
	luto@...nel.org, peterz@...radead.org, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, rafael@...nel.org, lenb@...nel.org,
	david@...hat.com, osalvador@...e.de, gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org, rppt@...nel.org
Subject: Re: [PATCH v5 2/3] x86: probe memory block size advisement value
 during mm init

On Fri, Nov 01, 2024 at 12:19:08PM -0400, Gregory Price wrote:
> I don't personally understand the implications of this switch off hand,
> probably warrants a separate patch submission if you think it's important
> given the original logic is boot_cpu_has and I don't want to increase
> scope change here.

We want to switch the code to cpu_feature_enabled():

https://lore.kernel.org/r/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local

and it is not increasing the scope at all. You can simply say:

"Convert to cpu_feature_enabled() while at it."

in the commit message.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette