linux-kernel - Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241101115417.dae7bfe1230575378e07a147@linux-foundation.org>
Date: Fri, 1 Nov 2024 11:54:17 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Shuah Khan <shuah@...nel.org>, kernel@...labora.com, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, Donet Tom
 <donettom@...ux.ibm.com>
Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to
 skip in the start

On Fri,  1 Nov 2024 19:15:57 +0500 Muhammad Usama Anjum <usama.anjum@...labora.com> wrote:

> The test should be skipped if initial conditions aren't fulfilled in
> the start instead of failing and outputting non-compliant TAP logs. This
> kind of failure pollutes the results. The initial conditions are:
> - The test should only execute if /tmp file can be allocated.
> - The test should only execute if huge pages are free.

Cc Donet Tom.

I added 

Fixes: 3a103b5315b7 ("selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()")
Cc: <stable@...r.kernel.org>

> ---
> Before:
> TAP version 13
> 1..4
> Bail out! Error opening file
> : Read-only file system (30)
>  # Planned tests != run tests (4 != 0)
>  # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> After:
> TAP version 13
> 1..0 # SKIP Unable to allocate file: Read-only file system
> ---

And I moved this useful information to the changelog.