linux-kernel - Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd5e58fa-4458-4680-be2c-e14d43d32572@stanley.mountain>
Date: Fri, 1 Nov 2024 10:04:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: akpm@...ux-foundation.org, kent.overstreet@...ux.dev, rppt@...nel.org,
	mcgrof@...nel.org, petr.pavlu@...e.com, samitolvanen@...gle.com,
	da.gomez@...sung.com, yuzhao@...gle.com, souravpanda@...gle.com,
	pasha.tatashin@...een.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling

On Thu, Oct 31, 2024 at 05:00:17PM -0700, Suren Baghdasaryan wrote:
> diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> index 1c74942e6dfd..00ab18ea452a 100644
> --- a/lib/alloc_tag.c
> +++ b/lib/alloc_tag.c
> @@ -437,7 +437,7 @@ static void *reserve_module_tags(struct module *mod, unsigned long size,
>  
>  	/* If no tags return NULL */
                      ^^^^^^^^^^^

>  	if (size < sizeof(struct alloc_tag))
> -		return NULL;
> +		return ERR_PTR(-EINVAL);
>  

Thanks for this.  We'd want to update the comment as well.

regards,
dan carpenter