linux-kernel - Re: [PATCH 1/1] alloc_tag: fix empty codetag module section handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241031174557.18b8f408a6b810b3fe7468c6@linux-foundation.org>
Date: Thu, 31 Oct 2024 17:45:57 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: kent.overstreet@...ux.dev, dan.carpenter@...aro.org, rppt@...nel.org,
 mcgrof@...nel.org, petr.pavlu@...e.com, samitolvanen@...gle.com,
 da.gomez@...sung.com, yuzhao@...gle.com, souravpanda@...gle.com,
 pasha.tatashin@...een.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] alloc_tag: fix empty codetag module section
 handling

On Thu, 31 Oct 2024 17:13:58 -0700 Suren Baghdasaryan <surenb@...gle.com> wrote:

> On Thu, Oct 31, 2024 at 5:00 PM Suren Baghdasaryan <surenb@...gle.com> wrote:
> >
> > When a module does not have any allocations, it's allocation tag section
> > is empty and codetag_alloc_module_section() returns NULL. However this
> > condition should never happen because codetag_needs_module_section() will
> > detect an empty section and avoid calling codetag_alloc_module_section().
> > Change codetag_alloc_module_section() to never return NULL, which should
> > prevent static checker warnings. Add a WARN_ON() and a proper error
> > reporting in case codetag_alloc_module_section() returns NULL, to prevent
> > future codetag type implementations from returning NULL from their
> > cttype->desc.alloc_section_mem() operation.
> >
> > Fixes: 61c9e58f3a10 ("alloc_tag: load module tags into separate contiguous memory")
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Closes: https://lore.kernel.org/all/50f12fa1-17c1-4940-a6bf-beaf61f6b17a@stanley.mountain/
> > Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
> 
> Andrew, I was going to respin v5 of my patchset and include all these
> small fixes in it but it's a bit tricky because I would have to revert
> another unrelated patch [1] from mm-unstable which refactors relevant
> code. So far the fixes are rather small, so I think you should not
> have much trouble folding them into the original patchset when the
> time comes, but if that becomes a problem I can prepare a new version.
> 

No probs, thanks, I figured it out.  The descriptions of
where-it-fits-and-why are helpful.

Of course we could just pile everything onto mm-unstable HEAD and live
with a messier commit history, but I think things are manageable at
present.