linux-kernel - Re: [PATCH net v3] net: wwan: t7xx: Fix off-by-one error in t7xx_dpmaif_rx_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1645aca2-2231-6ac4-d8cf-eddbb16259be@linux.intel.com>
Date: Fri, 1 Nov 2024 10:38:23 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
cc: chandrashekar.devegowda@...el.com, chiranjeevi.rapolu@...ux.intel.com, 
    haijun.liu@...iatek.com, m.chetan.kumar@...ux.intel.com, 
    ricardo.martinez@...ux.intel.com, loic.poulain@...aro.org, 
    ryazanov.s.a@...il.com, johannes@...solutions.net, andrew+netdev@...n.ch, 
    davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
    pabeni@...hat.com, Netdev <netdev@...r.kernel.org>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3] net: wwan: t7xx: Fix off-by-one error in
 t7xx_dpmaif_rx_buf_alloc()

On Fri, 1 Nov 2024, Jinjie Ruan wrote:

> The error path in t7xx_dpmaif_rx_buf_alloc(), free and unmap the already
> allocated and mapped skb in a loop, but the loop condition terminates when
> the index reaches zero, which fails to free the first allocated skb at
> index zero.
> 
> Check with i-- so that skb at index 0 is freed as well.
> 
> Cc: stable@...r.kernel.org
> Fixes: d642b012df70 ("net: wwan: t7xx: Add data path interface")
> Acked-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
> v3:
> - Remove suggested-by.
> - Use i-- to simplify the fix.
> - Add Acked-by.
> - Add cc stable.
> - Update the commit message.
> v2:
> - Update the commit title.
> - Declare i as signed to avoid the endless loop.
> ---
>  drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c
> index 210d84c67ef9..7a9c09cd4fdc 100644
> --- a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c
> +++ b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c
> @@ -226,7 +226,7 @@ int t7xx_dpmaif_rx_buf_alloc(struct dpmaif_ctrl *dpmaif_ctrl,
>  	return 0;
>  
>  err_unmap_skbs:
> -	while (--i > 0)
> +	while (i--)
>  		t7xx_unmap_bat_skb(dpmaif_ctrl->dev, bat_req->bat_skb, i);
>  
>  	return ret;
> 

Thanks.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.