linux-kernel - Re: [PATCH net v3] net: wwan: t7xx: Fix off-by-one error in t7xx_dpmaif_rx_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <736ec702-32ba-4dbd-a16c-b6d9a3ea99d8@web.de>
Date: Sat, 2 Nov 2024 10:31:15 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jinjie Ruan <ruanjinjie@...wei.com>, netdev@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>,
 Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
 Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jakub Kicinski <kuba@...nel.org>, Johannes Berg <johannes@...solutions.net>,
 Liu Haijun <haijun.liu@...iatek.com>, Loic Poulain
 <loic.poulain@...aro.org>, M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
 Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3] net: wwan: t7xx: Fix off-by-one error in
 t7xx_dpmaif_rx_buf_alloc()

…
> Check with i-- so that skb at index 0 is freed as well.
…

Is the same source code adjustment needed also for the implementation
of the function “t7xx_dpmaif_rx_frag_alloc”?
https://elixir.bootlin.com/linux/v6.12-rc5/source/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c#L384

Regards,
Markus