linux-kernel - Re: [PATCH asahi-soc/dt 01/10] dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e0b5238-d781-458a-9285-df54a16232af@marcan.st>
Date: Fri, 1 Nov 2024 21:33:32 +0900
From: Hector Martin <marcan@...can.st>
To: Krzysztof Kozlowski <krzk@...nel.org>, Nick Chan <towinchenmi@...il.com>
Cc: Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig
 <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH asahi-soc/dt 01/10] dt-bindings: arm: apple: apple,pmgr:
 Add A7-A11 compatibles

On 2024/10/29 16:41, Krzysztof Kozlowski wrote:
> On Tue, Oct 29, 2024 at 09:03:59AM +0800, Nick Chan wrote:
>> The blocks found on Apple A7-A11 SoCs are compatible with the existing
>> driver so add their per-SoC compatibles.
>>
>> Signed-off-by: Nick Chan <towinchenmi@...il.com>
>> ---
>>  Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> index 673277a7a224..5001f4d5a0dc 100644
>> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> @@ -22,6 +22,11 @@ properties:
>>    compatible:
>>      items:
>>        - enum:
>> +          - apple,s5l8960x-pmgr
>> +          - apple,t7000-pmgr
>> +          - apple,s8000-pmgr
>> +          - apple,t8010-pmgr
>> +          - apple,t8015-pmgr
> 
> Assuming you keep the existing order of entries in this file, which is
> different than usually expected: alphanumeric.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Yeah, it's a bit ad-hoc but essentially "by release date" with a fork at
t6000. So:

- First the ancient s5l series
- Then all the t/sXXXX chips up to t8103 (M1) (numeric order, ignoring
prefix letter)
- Then the rest of the "baseline" Ax,Mx chips that continue after M1,
which are all numbered t8xxx (numeric order)
- Finally the t6xxx series (Mx Pro/Mx Max), which forks the timeline and
numbering after t8103/M1 (M1 Pro = t6000).

Unless there's significant objection I'd like to keep this pattern, it
makes sense from the POV of people working on these chips.

- Hector