[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <23074410-ffe2-4f68-a983-67cec430f68f@marcan.st>
Date: Fri, 1 Nov 2024 21:41:13 +0900
From: Hector Martin <marcan@...can.st>
To: Nick Chan <towinchenmi@...il.com>, Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH asahi-soc/dt 00/10] Add PMGR nodes for Apple A7-A11 SoCs
On 2024/10/29 10:03, Nick Chan wrote:
> This series adds the PMGR nodes and all known power state subnodes for
> Apple A7-A11 SoCs, along with the associated dt-bindings.
>
> ---
> Nick Chan (10):
> dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles
> dt-bindings: arm: apple: apple,pmgr-pwrstate: Add A7-A11 compatibles
> arm64: dts: apple: s5l8960x: Add PMGR node
> arm64: dts: apple: t7000: Add PMGR node
> arm64: dts: apple: t7001: Add PMGR node
> arm64: dts: apple: s8000: Add PMGR nodes
> arm64: dts: apple: s8001: Add PMGR nodes
> arm64: dts: apple: t8010: Add PMGR nodes
> arm64: dts: apple: t8011: Add PMGR nodes
> arm64: dts: apple: t8015: Add PMGR nodes
>
> .../bindings/arm/apple/apple,pmgr.yaml | 5 +
> .../bindings/power/apple,pmgr-pwrstate.yaml | 5 +
> arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi | 4 +
> .../arm64/boot/dts/apple/s5l8960x-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi | 610 ++++++++++++
> arch/arm64/boot/dts/apple/s5l8960x.dtsi | 13 +
> .../arm64/boot/dts/apple/s800-0-3-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/s8000-pmgr.dtsi | 757 ++++++++++++++
> arch/arm64/boot/dts/apple/s8000.dtsi | 22 +
> arch/arm64/boot/dts/apple/s8001-common.dtsi | 1 +
> .../arm64/boot/dts/apple/s8001-j98a-j99a.dtsi | 26 +
> arch/arm64/boot/dts/apple/s8001-j98a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-j99a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-pmgr.dtsi | 823 ++++++++++++++++
> arch/arm64/boot/dts/apple/s8001.dtsi | 22 +
> arch/arm64/boot/dts/apple/s800x-6s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-ipad5.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-se.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-handheld.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-j42d.dts | 1 +
> arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-n102.dts | 4 +
> arch/arm64/boot/dts/apple/t7000-pmgr.dtsi | 641 ++++++++++++
> arch/arm64/boot/dts/apple/t7000.dtsi | 14 +
> arch/arm64/boot/dts/apple/t7001-air2.dtsi | 1 +
> arch/arm64/boot/dts/apple/t7001-pmgr.dtsi | 650 ++++++++++++
> arch/arm64/boot/dts/apple/t7001.dtsi | 13 +
> arch/arm64/boot/dts/apple/t8010-7.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8010-ipad6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-n112.dts | 4 +
> arch/arm64/boot/dts/apple/t8010-pmgr.dtsi | 772 +++++++++++++++
> arch/arm64/boot/dts/apple/t8010.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8011-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8011-pmgr.dtsi | 807 +++++++++++++++
> arch/arm64/boot/dts/apple/t8011-pro2.dtsi | 8 +
> arch/arm64/boot/dts/apple/t8011.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8015-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8015-pmgr.dtsi | 931 ++++++++++++++++++
> arch/arm64/boot/dts/apple/t8015.dtsi | 21 +
> 43 files changed, 6246 insertions(+)
> create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8000-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-j98a-j99a.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7000-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8010-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8011-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8015-pmgr.dtsi
>
>
> base-commit: 5c9de6f45db36b8a74c12e448cf9db87c97bf1e5
I'm not going to review the actual pmgr spam (I assume you did the usual
thing and autogenerated it with the m1n1 scripts and then fixed some
things up by hand, as we do), since really the only useful way to
validate this is testing and I don't have these devices (nor am I
familiar with any peculiarities).
Skimming the rest of the changes it looks reasonable, so:
Acked-by: Hector Martin <marcan@...can.st>
Would be nice to get at least a cursory review from the DT folks, I'll
apply to the SoC tree after that (please poke me via direct/non-PATCH
email if I miss it, those go in a different inbox).
- Hector
Powered by blists - more mailing lists