[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241102083608.GA308136@robin.jannau.net>
Date: Sat, 2 Nov 2024 09:36:08 +0100
From: Janne Grunau <j@...nau.net>
To: Nick Chan <towinchenmi@...il.com>
Cc: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: apple,spi: Add binding for
Apple SPI controllers
On Sat, Nov 02, 2024 at 10:36:56AM +0800, Nick Chan wrote:
>
>
> On 2/11/2024 03:26, Janne Grunau via B4 Relay wrote:
>
> [...]
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - apple,t8103-spi
> > + - apple,t8112-spi
> > + - apple,t6000-spi
> > + - const: apple,spi
> Apple A7-A11 SoCs seems to use a Samsung SPI block, so apple,spi is too
> generic. Fallback to something like apple,t8103-spi instead.
Have you looked at it? This one still seems to be somehow Samsung
related. See the previous discussion at
https://lore.kernel.org/linux-devicetree/d87ae109-4b58-7465-b16e-3bf7c9d60f1f@marcan.st/
Even the A7-A11 SPI controllers are not compatible "apple,spi" doesn't
prevent us from using something like "apple,s5l-spi" for those.
Janne
Powered by blists - more mailing lists