linux-kernel - Re: [PATCH v2 13/15] iio: light: apds9306: simplifies if branch in apds9306_write_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEHHSva6+Br9rXE9n0wqXuwQqetXN=Ae5vg0rxmPRfCVdw9atA@mail.gmail.com>
Date: Sat, 2 Nov 2024 15:29:35 +0100
From: Julien Stephan <jstephan@...libre.com>
To: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Mudit Sharma <muditsharma.info@...il.com>, 
	Lars-Peter Clausen <lars@...afoo.de>, Anshul Dalal <anshulusr@...il.com>, 
	Javier Carrasco <javier.carrasco.cruz@...il.com>, 
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Cosmin Tanislav <cosmin.tanislav@...log.com>, 
	Ramona Gradinariu <ramona.gradinariu@...log.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>, 
	Dan Robertson <dan@...obertson.com>, Marcelo Schmitt <marcelo.schmitt@...log.com>, 
	Matteo Martelli <matteomartelli3@...il.com>, 
	Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>, Michal Simek <michal.simek@....com>, 
	Mariel Tinaco <Mariel.Tinaco@...log.com>, Jagath Jog J <jagathjog1996@...il.com>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, Kevin Tsai <ktsai@...ellamicro.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Benson Leung <bleung@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v2 13/15] iio: light: apds9306: simplifies if branch in apds9306_write_event_config

Le sam. 2 nov. 2024 à 14:21, Subhajit Ghosh
<subhajit.ghosh@...aklogic.com> a écrit :
>
> On 2/11/24 03:11, Jonathan Cameron wrote:
> > On Thu, 31 Oct 2024 16:27:08 +0100
> > Julien Stephan <jstephan@...libre.com> wrote:
> >
> >> Simplifies the regmap_wite if branch in apds9306_write_event_config.
> > Applied.
> >>
> >> Signed-off-by: Julien Stephan <jstephan@...libre.com>
> >> ---
> >>   drivers/iio/light/apds9306.c | 5 +----
> >>   1 file changed, 1 insertion(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> >> index 8adc74040db2bddf93fbb773e3519abcc726b9a6..9c08e7c3ad0c17519689a630d42fe9b90438dfe8 100644
> >> --- a/drivers/iio/light/apds9306.c
> >> +++ b/drivers/iio/light/apds9306.c
> >> @@ -1125,10 +1125,7 @@ static int apds9306_write_event_config(struct iio_dev *indio_dev,
> >>              }
> >>      }
> >>      case IIO_EV_TYPE_THRESH_ADAPTIVE:
> >> -            if (state)
> >> -                    return regmap_field_write(rf->int_thresh_var_en, 1);
> >> -            else
> >> -                    return regmap_field_write(rf->int_thresh_var_en, 0);
> >> +            return regmap_field_write(rf->int_thresh_var_en, state);
> >>      default:
> >>              return -EINVAL;
> >>      }
> >>
> >
> Hi Julien,
> Sorry for the delay.
> "int_thresh_var_en" corresponds to APDS9306_INT_CFG_REG bit 3 (Datasheet: INT_CFG, Address: 0x19) which
> is a single bit value only. If user does "echo 4 > /sys/bus/iio/devices/iio:device0/events/thresh_adaptive_either_en",
> which trickles down to the "state" variable, do we really want to write any other value except "0" or "1"?
> Correct me if I am wrong here.

Hi Subhajit,
In drivers/iio/industrialio-event.c, iio_ev_state_store is actually
using kstrtobool to check user input, then gives the converted boolean
value to write_event_config.
So state is a boolean. By the way the purpose of this series is to
clean up code and use a bool instead of int for the state parameter.

So new code is equivalent to what was there before.
Cheers
Julien


> Regards,
> Subhajit Ghosh