linux-kernel - Re: [PATCH 05/10] x86/mce/genpool: Make mce_gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed3tr9kn.ffs@tglx>
Date: Sat, 02 Nov 2024 15:31:36 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>, tony.luck@...el.com, bp@...en8.de
Cc: dave.hansen@...ux.intel.com, mingo@...hat.com, hpa@...or.com,
 x86@...nel.org, linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
 qiuxu.zhuo@...el.com
Subject: Re: [PATCH 05/10] x86/mce/genpool: Make mce_gen_pool_create()
 return explicit error codes

On Thu, Oct 10 2024 at 23:31, Qiuxu Zhuo wrote:

> Make mce_gen_pool_create() return explicit error codes for better
> readability.

What's the point?

All error paths including gen_pool_add() return -ENOMEM.

The call site just cares about success or fail.

So this can simply be converted to bool and return true on success and
false otherwise.

Thanks,

        tglx