linux-kernel - RE: [PATCH 05/10] x86/mce/genpool: Make mce_gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134A8A89F8CCF83FF24803489502@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Sun, 3 Nov 2024 00:42:41 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Thomas Gleixner <tglx@...utronix.de>, "Luck, Tony" <tony.luck@...el.com>,
	"bp@...en8.de" <bp@...en8.de>
CC: "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"mingo@...hat.com" <mingo@...hat.com>, "hpa@...or.com" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 05/10] x86/mce/genpool: Make mce_gen_pool_create() return
 explicit error codes

> From: Thomas Gleixner <tglx@...utronix.de>
> [...]
> On Thu, Oct 10 2024 at 23:31, Qiuxu Zhuo wrote:
> 
> > Make mce_gen_pool_create() return explicit error codes for better
> > readability.
> 
> What's the point?
> 
> All error paths including gen_pool_add() return -ENOMEM.
> 
> The call site just cares about success or fail.
> 
> So this can simply be converted to bool and return true on success and false
> otherwise.

Yes, this way it's much cleaner. 
Thank you, Thomas, for your kind guidance.

> Thanks,
> 
>         tglx