linux-kernel - Re: [PATCH v4 09/17] wifi: cc33xx: Add main.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2fd6c15-6b30-4777-93ae-d20b0c4a76a0@ti.com>
Date: Sun, 3 Nov 2024 14:55:57 +0200
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Simon Horman <horms@...nel.org>
CC: Kalle Valo <kvalo@...nel.org>, "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Sabeeh Khan
	<sabeeh-khan@...com>
Subject: Re: [PATCH v4 09/17] wifi: cc33xx: Add main.c

On 11/2/2024 3:25 PM, Simon Horman wrote:

...
> 
> Hi Michael,
> 
> Sparse seems a bit unhappy about this:
> 
> .../main.c:332:24: warning: incorrect type in initializer (different address spaces)
> .../main.c:332:24:    expected struct ieee80211_sband_iftype_data const [noderef] __iftype_data *iftype_data
> .../main.c:332:24:    got struct ieee80211_sband_iftype_data *
> 
> So perhaps it should be:
> 
> static const struct ieee80211_sband_iftype_data __iftd iftype_data_2ghz[] = {{
> 
> Likewise for iftype_data_5ghz.
> 

Hi Simon,

Yeah I saw that and was unsure how to properly solve it, Sparse does not 
seems to like direct use of this variable. The above is based on old 
code and I see newer implementations are using 
ieee80211_set_sband_iftype_data which has the casting that should make 
Sparse at ease. I'll try migrating the CC33xx code to this convention 
which will require moving some structs around.

Thanks and regards,
Michael.