linux-kernel - Re: [PATCH v4 04/17] wifi: cc33xx: Add sdio.c, io.c, io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2c01b4b-769e-4409-a8e7-90792b2ce2a1@ti.com>
Date: Sun, 3 Nov 2024 15:33:52 +0200
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC: Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH v4 04/17] wifi: cc33xx: Add sdio.c, io.c, io.h

On 10/29/2024 7:34 PM, Krzysztof Kozlowski wrote:

...

>> +
>> +void cc33xx_disable_interrupts_nosync(struct cc33xx *cc)
>> +{
>> +	cc->if_ops->disable_irq(cc->dev);
>> +}
>> +
>> +void cc33xx_irq(void *cookie);
> 
> Why do you need forward declaration of non-static function? If you need
> it, it means you had W=1 warning which you fixed incorrect way.
> 
> Regardless, be sure this code has 0 warnings on clang with W=1.
> 

Indeed a refactoring leftover (already moved to a header file) will fix.

...

>> +
>> +static struct sdio_driver cc33xx_sdio_driver = {
>> +	.name		= "cc33xx_sdio",
>> +	.id_table	= cc33xx_devices,
>> +	.probe		= sdio_cc33xx_probe,
>> +	.remove		= sdio_cc33xx_remove,
>> +#ifdef CONFIG_PM
>> +	.drv = {
>> +		.pm = &cc33xx_sdio_pm_ops,
>> +	},
>> +#endif /* CONFIG_PM */
>> +};
>> +
>> +MODULE_DEVICE_TABLE(sdio, cc33xx_devices);
> 
> This is always next to the table.
> 

Will fix.

Regards,
Michael.