linux-kernel - Re: [PATCH] kbuild: add resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce5b3247-c682-47f1-b503-154b5d48bffc@t-8ch.de>
Date: Sun, 3 Nov 2024 04:39:38 +0000
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Peter Jung <admin@...1337.dev>
Cc: jose.fernandez@...ux.dev, Christian Heusel <christian@...sel.eu>, 
	Nathan Chancellor <nathan@...nel.org>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bpf@...r.kernel.org
Subject: Re: [PATCH] kbuild: add resolve_btfids to pacman PKGBUILD

On 2024-11-02 13:05:26+0100, Peter Jung wrote:
> If the config is using DEBUG_INFO_BTF, it is required to,
> package resolve_btfids with.

This sentence sounds weird.

> Compiling dkms modules will fail otherwise.

Maybe we should add it to scripts/package/install-extmod-build so it
also works for all the other package types?

> Add a check, if resolve_btfids is present and then package it, if required.
> 
> Signed-off-by: Peter Jung <admin@...1337.dev>
> ---
>  scripts/package/PKGBUILD | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index f83493838cf9..4010899652b8 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -91,6 +91,11 @@ _package-headers() {
>  		"${srctree}/scripts/package/install-extmod-build" "${builddir}"
>  	fi
>  
> +	# required when DEBUG_INFO_BTF_MODULES is enabled
> +	if [ -f tools/bpf/resolve_btfids/resolve_btfids ]; then

I would prefer to actually test for DEBUG_INFO_BTF_MODULES instead of
file existence. This file may be stale when the option got disabled.

> +		install -Dt "$builddir/tools/bpf/resolve_btfids" tools/bpf/resolve_btfids/resolve_btfids
> +	fi
> +
>  	echo "Installing System.map and config..."
>  	mkdir -p "${builddir}"
>  	cp System.map "${builddir}/System.map"
> -- 
> 2.47.0
>