[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNAQ=sCsTXB_O58W=AH=k8Vqzoi+hh6-BKhEjZYh-+xCvBQ@mail.gmail.com>
Date: Sun, 3 Nov 2024 18:47:14 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Peter Jung <admin@...1337.dev>
Cc: jose.fernandez@...ux.dev, Thomas Weißschuh <linux@...ssschuh.net>,
Christian Heusel <christian@...sel.eu>, Nathan Chancellor <nathan@...nel.org>,
Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] kbuild: add resolve_btfids to pacman PKGBUILD
On Sat, Nov 2, 2024 at 9:06 PM Peter Jung <admin@...1337.dev> wrote:
>
> If the config is using DEBUG_INFO_BTF, it is required to,
> package resolve_btfids with.
> Compiling dkms modules will fail otherwise.
>
> Add a check, if resolve_btfids is present and then package it, if required.
>
> Signed-off-by: Peter Jung <admin@...1337.dev>
> ---
> scripts/package/PKGBUILD | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index f83493838cf9..4010899652b8 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -91,6 +91,11 @@ _package-headers() {
> "${srctree}/scripts/package/install-extmod-build" "${builddir}"
> fi
>
> + # required when DEBUG_INFO_BTF_MODULES is enabled
> + if [ -f tools/bpf/resolve_btfids/resolve_btfids ]; then
> + install -Dt "$builddir/tools/bpf/resolve_btfids" tools/bpf/resolve_btfids/resolve_btfids
> + fi
> +
This is not the right place.
scripts/package/install-extmod-build is a script to set up
the build environment to build external modules.
It is shared by rpm-pkg, deb-pkg, and pacman-pkg.
https://github.com/torvalds/linux/blob/v6.12-rc5/scripts/package/install-extmod-build#L34
You will see how objtool is copied.
(Anyway, it depends on your urgency.
My hope is to support objtool and resolve_btfids in more generic ways.)
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists