linux-kernel - Re: [PATCH] kbuild: add resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5c2bf57-c051-40e3-a4a6-ccd38b728752@ptr1337.dev>
Date: Mon, 4 Nov 2024 15:44:04 +0100
From: Peter Jung <admin@...1337.dev>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: jose.fernandez@...ux.dev, Thomas Weißschuh
 <linux@...ssschuh.net>, Christian Heusel <christian@...sel.eu>,
 Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH] kbuild: add resolve_btfids to pacman PKGBUILD


On 03.11.24 10:47, Masahiro Yamada wrote:
> On Sat, Nov 2, 2024 at 9:06 PM Peter Jung<admin@...1337.dev> wrote:
>> If the config is using DEBUG_INFO_BTF, it is required to,
>> package resolve_btfids with.
>> Compiling dkms modules will fail otherwise.
>>
>> Add a check, if resolve_btfids is present and then package it, if required.
>>
>> Signed-off-by: Peter Jung<admin@...1337.dev>
>> ---
>>   scripts/package/PKGBUILD | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
>> index f83493838cf9..4010899652b8 100644
>> --- a/scripts/package/PKGBUILD
>> +++ b/scripts/package/PKGBUILD
>> @@ -91,6 +91,11 @@ _package-headers() {
>>                  "${srctree}/scripts/package/install-extmod-build" "${builddir}"
>>          fi
>>
>> +       # required when DEBUG_INFO_BTF_MODULES is enabled
>> +       if [ -f tools/bpf/resolve_btfids/resolve_btfids ]; then
>> +               install -Dt "$builddir/tools/bpf/resolve_btfids" tools/bpf/resolve_btfids/resolve_btfids
>> +       fi
>> +
> This is not the right place.
>
> scripts/package/install-extmod-build is a script to set up
> the build environment to build external modules.
> It is shared by rpm-pkg, deb-pkg, and pacman-pkg.
>
>
> https://github.com/torvalds/linux/blob/v6.12-rc5/scripts/package/install-extmod-build#L34
>
> You will see how objtool is copied.
>
>
>
>
> (Anyway, it depends on your urgency.
> My hope is to support objtool and resolve_btfids in more generic ways.)
>

Thanks Masahiro for the suggestion. I will look into and likely bring a v2.
I did not know about other distribution/package managers, if this is 
also a problem at them.

At archlinux we have included this since a while already in the 
PKGBUILD, see here:
https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/blob/main/PKGBUILD?ref_type=heads#L151-152

I will also make the change to grep for DEBUG_INFO_BTF in the config 
with the is_enabled function, instead of checking the path


Regards,

Peter