linux-kernel - Re: [PATCH] pm-graph: Refactor installation script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h_yu6YHcYRPSOg5yrrvWd-Mv4+xYtU+XouP2APoydm+w@mail.gmail.com>
Date: Mon, 4 Nov 2024 17:20:09 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Amit Vadhavana <av2082000@...il.com>, todd.e.brandt@...ux.intel.com
Cc: skhan@...uxfoundation.org, ricardo@...liere.net, 
	linux-kernel-mentees@...ts.linux.dev, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pm-graph: Refactor installation script

On Fri, Nov 1, 2024 at 3:53 PM Amit Vadhavana <av2082000@...il.com> wrote:
>
> Change installation script to ensure that the terminal returns to the
> original directory after the installation process completes.
>
> Signed-off-by: Amit Vadhavana <av2082000@...il.com>
> ---
>  tools/power/pm-graph/install_latest_from_github.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tools/power/pm-graph/install_latest_from_github.sh b/tools/power/pm-graph/install_latest_from_github.sh
> index eaa332399d36..aaf3515400ed 100755
> --- a/tools/power/pm-graph/install_latest_from_github.sh
> +++ b/tools/power/pm-graph/install_latest_from_github.sh
> @@ -4,6 +4,9 @@
>  # Script which clones and installs the latest pm-graph
>  # from http://github.com/intel/pm-graph.git
>
> +# Save the current directory
> +CURRENT_DIR=$(pwd)
> +
>  OUT=`mktemp -d 2>/dev/null`
>  if [ -z "$OUT" -o ! -e $OUT ]; then
>         echo "ERROR: mktemp failed to create folder"
> @@ -36,3 +39,6 @@ else
>         echo "INSTALL FAILED"
>  fi
>  cleanup
> +
> +# Return to the original directory
> +cd "$CURRENT_DIR"
> --

Todd, can you please let me know if this is OK?