linux-kernel - Re: [PATCH] rust: irq: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D72CA8B1-E71E-410C-AD7E-D7A81CC3F807@collabora.com>
Date: Mon, 4 Nov 2024 16:19:23 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Boris Brezillon <boris.brezillon@...labora.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: irq: add support for request_irq()

Hi Alice,


> On 29 Oct 2024, at 08:59, Alice Ryhl <aliceryhl@...gle.com> wrote:
> 
> On Thu, Oct 24, 2024 at 4:20 PM Daniel Almeida
> <daniel.almeida@...labora.com> wrote:
>> 
>> Both regular and threaded versions are supported.
>> 
>> Signed-off-by: Daniel Almeida <daniel.almeida@...labora.com>
> 
> Why implement request_irq over devm_request_irq?
> 
> Alice
> 

As we spoke earlier, and for the record, devm will automate the
lifetime of a resource, taking care to relinquish it when the driver
is unloaded.

I feel better with an explicit `Drop` implementation, which is why
the devm versions were not chosen. IMHO, the problem it was
designed to solve often simply does not apply to Rust code.

— Daniel