linux-kernel - Re: [PATCH v2 06/10] sysfs: treewide: constify attribute callback of bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b8312490c668a99b2a89667b7d1cbdf2019b885.camel@linux.ibm.com>
Date: Mon, 04 Nov 2024 12:24:55 +1100
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Thomas Weißschuh <linux@...ssschuh.net>,
        Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki"
 <rafael@...nel.org>,
        Bjorn Helgaas	 <bhelgaas@...gle.com>,
        Srinivas
 Kandagatla <srinivas.kandagatla@...aro.org>,
        Davidlohr Bueso
 <dave@...olabs.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Dave
 Jiang	 <dave.jiang@...el.com>,
        Alison Schofield
 <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira
 Weiny <ira.weiny@...el.com>,
        Alex Deucher	 <alexander.deucher@....com>,
        Christian König	 <christian.koenig@....com>,
        Xinhui Pan
 <Xinhui.Pan@....com>, David Airlie	 <airlied@...il.com>,
        Simona Vetter
 <simona@...ll.ch>,
        Dennis Dalessandro	
 <dennis.dalessandro@...nelisnetworks.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky	 <leon@...nel.org>,
        Tudor Ambarus
 <tudor.ambarus@...aro.org>,
        Pratyush Yadav	 <pratyush@...nel.org>,
        Michael
 Walle <mwalle@...nel.org>,
        Miquel Raynal	 <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>,
        Carlos Bilbao	
 <carlos.bilbao.osdev@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>,
        "David E. Box"
 <david.e.box@...ux.intel.com>,
        "James E.J. Bottomley"	
 <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"	
 <martin.petersen@...cle.com>,
        Richard Henderson
 <richard.henderson@...aro.org>,
        Matt Turner <mattst88@...il.com>,
        Frederic
 Barrat <fbarrat@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>, Logan
 Gunthorpe <logang@...tatee.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang	 <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
        Dexuan Cui	 <decui@...rosoft.com>
Cc: Dan Williams <dan.j.williams@...el.com>, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-cxl@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-rdma@...r.kernel.org, linux-mtd@...ts.infradead.org,
        platform-driver-x86@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-alpha@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH v2 06/10] sysfs: treewide: constify attribute callback
 of bin_attribute::mmap()

On Sun, 2024-11-03 at 17:03 +0000, Thomas Weißschuh wrote:
> The mmap() callbacks should not modify the struct
> bin_attribute passed as argument.
> Enforce this by marking the argument as const.
> 
> As there are not many callback implementers perform this change
> throughout the tree at once.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Acked-by: Andrew Donnellan <ajd@...ux.ibm.com> # ocxl

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited