linux-kernel - Re: [PATCH RESEND net-next] net: tcp: replace the document for "lsndtime" in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1730698521.639766-1-xuanzhuo@linux.alibaba.com>
Date: Mon, 4 Nov 2024 13:35:21 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: dsahern@...nel.org,
 kuba@...nel.org,
 weiwan@...gle.com,
 netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Menglong Dong <dongml2@...natelecom.cn>,
 edumazet@...gle.com,
 lixiaoyan@...gle.com
Subject: Re: [PATCH RESEND net-next] net: tcp: replace the document for "lsndtime" in tcp_sock

On Wed, 30 Oct 2024 19:31:08 +0800, Menglong Dong <menglong8.dong@...il.com> wrote:
> The document for "lsndtime" in struct tcp_sock is placed in the wrong
> place, so let's replace it in the proper place.
>
> Fixes: d5fed5addb2b ("tcp: reorganize tcp_sock fast path variables")
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>

Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>


> ---
>  include/linux/tcp.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index 6a5e08b937b3..f88daaa76d83 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -200,7 +200,6 @@ struct tcp_sock {
>
>  	/* TX read-mostly hotpath cache lines */
>  	__cacheline_group_begin(tcp_sock_read_tx);
> -	/* timestamp of last sent data packet (for restart window) */
>  	u32	max_window;	/* Maximal window ever seen from peer	*/
>  	u32	rcv_ssthresh;	/* Current window clamp			*/
>  	u32	reordering;	/* Packet reordering metric.		*/
> @@ -263,7 +262,7 @@ struct tcp_sock {
>  	u32	chrono_stat[3];	/* Time in jiffies for chrono_stat stats */
>  	u32	write_seq;	/* Tail(+1) of data held in tcp send buffer */
>  	u32	pushed_seq;	/* Last pushed seq, required to talk to windows */
> -	u32	lsndtime;
> +	u32	lsndtime;	/* timestamp of last sent data packet (for restart window) */
>  	u32	mdev_us;	/* medium deviation			*/
>  	u32	rtt_seq;	/* sequence number to update rttvar	*/
>  	u64	tcp_wstamp_ns;	/* departure time for next sent data packet */
> --
> 2.39.5
>
>