[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5340fb82-bda0-d22f-23df-de620c8d61c3@denx.de>
Date: Mon, 4 Nov 2024 06:33:55 +0100
From: Heiko Schocher <hs@...x.de>
To: Shawn Guo <shawnguo2@...h.net>
Cc: linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: imx8mp: add aristainetos3 board
support
Hello Shawn,
removed the changes which are clear...
On 03.11.24 10:41, Shawn Guo wrote:
> On Thu, Oct 31, 2024 at 04:12:37PM +0100, Heiko Schocher wrote:
>> Add support for the i.MX8MP based aristainetos3 boards from ABB.
>>
>> The board uses a ABB specific SoM from ADLink, based on NXP
>> i.MX8MP SoC. The SoM is used on 3 different carrier boards,
>> with small differences.
>>
>> Signed-off-by: Heiko Schocher <hs@...x.de>
>> ---
>>
[...]
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-aristainetos3a-som-v1.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-aristainetos3a-som-v1.dtsi
>> new file mode 100644
>> index 000000000000..ced35e1d72b7
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-aristainetos3a-som-v1.dtsi
[...]
>> + pcie0_refclk: pcie0-refclk {
>
> Can we name the node clock-xxx?
renamed from rename pcie0-refclk to clock-pcie0-ref
[...]
>> + /* SX1509(0) U2605 */
>> + gpio6: pinctrl@3f {
>> + #gpio-cells = <2>;
>> + #interrupt-cells = <2>;
>> + compatible = "semtech,sx1509q";
>> + reg = <0x3f>;
I moved compatible and reg to the beginning of the node,
as you commented this also on other places.
>> +
>> + semtech,probe-reset;
>> + gpio-controller;
>> + interrupt-controller;
>> +
>> + interrupt-parent = <&gpio1>;
>> + interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
>> + };
Should I remove newlines here too?... but looking into the example from
Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
there are this newlines ... so I let this lines in... or?
>> +
>> + /* SX1509(1) U2606 */
>> + gpio7: pinctrl@70 {
>> + #gpio-cells = <2>;
>> + #interrupt-cells = <2>;
>> + compatible = "semtech,sx1509q";
>> + reg = <0x70>;
I moved compatible and reg to the beginning of the node here too.
>> +
>> + semtech,probe-reset;
>> + gpio-controller;
>> + interrupt-controller;
>> +
>> + interrupt-parent = <&gpio4>;
>> + interrupts = <19 IRQ_TYPE_EDGE_FALLING>;
>> +
>> + gpio6-cfg {
>> + pins = "gpio6";
>> + output-high;
>> + };
>> +
>> + gpio7-cfg {
>> + pins = "gpio7";
>> + output-high;
>> + };
>> + };
and let the newlines as I did...
>> +
>> + /* RTC U2607 */
>> + rtc0: rtc@51 {
>
> I2C slave nodes should be sorted in addresses.
done.
>
>> + compatible = "nxp,pcf8563";
>> + reg = <0x51>;
>> + #clock-cells = <0>;
>> + };
>> +};
>> +
>> +&irqsteer_hdmi {
>> + status = "okay";
>> +};
>> +
>> +&lcdif1 {
>> + status = "disabled";
>> +};
>> +
>> +&lcdif2 {
>> + status = "disabled";
>> +};
>> +
>> +/* HDMI */
>> +&lcdif3 {
>> + status = "okay";
>> +
>
> Unneeded newline.
Many thanks for your review, and sorry, for trivial fixes...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@...x.de
Powered by blists - more mailing lists