linux-kernel - RE: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <133e223b22df4ab4b4802163d0c42407@huawei.com>
Date: Mon, 4 Nov 2024 08:56:18 +0000
From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
To: liulongfang <liulongfang@...wei.com>, Alex Williamson
	<alex.williamson@...hat.com>
CC: "jgg@...dia.com" <jgg@...dia.com>, Jonathan Cameron
	<jonathan.cameron@...wei.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxarm@...neuler.org" <linuxarm@...neuler.org>
Subject: RE: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
 migration driver



> -----Original Message-----
> From: liulongfang <liulongfang@...wei.com>
> Sent: Monday, November 4, 2024 8:31 AM
> To: Alex Williamson <alex.williamson@...hat.com>
> Cc: jgg@...dia.com; Shameerali Kolothum Thodi
> <shameerali.kolothum.thodi@...wei.com>; Jonathan Cameron
> <jonathan.cameron@...wei.com>; kvm@...r.kernel.org; linux-
> kernel@...r.kernel.org; linuxarm@...neuler.org
> Subject: Re: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> migration driver
[...]

> >>> +
> >>> +	seq_printf(seq,
> >>> +		 "acc device:\n"
> >>> +		 "guest driver load: %u\n"
> >>> +		 "device opened: %d\n"
> >>> +		 "migrate data length: %lu\n",
> >>> +		 hisi_acc_vdev->vf_qm_state,
> >>> +		 hisi_acc_vdev->dev_opened,
> >>> +		 debug_migf->total_length);
> >>
> >> This debugfs entry is described as returning the data from the last
> >> migration, but vf_qm_state and dev_opened are relative to the current
> >> device/guest driver state.  Both seem to have no relevance to the data
> >> in debug_migf.
> >>
> >
> > The benefit of dev_opened retention is that user can obtain the device
> status
> > during the cat migf_data operation.
> >
> 
> I will remove dev_opened in the next version.
> And hisi_acc_vdev->vf_qm_state is changed to debug_migf-
> >vf_data.vf_qm_state
> Keep information about whether the device driver in the Guest OS is loaded
> when live migration occurs.

I think you already get that when you dump debug_migf->vf_data.
So not required.

Thanks,
Shameer