[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d0e80aa2-b44a-1862-bdcb-aa8268cc0fc5@huawei.com>
Date: Mon, 4 Nov 2024 17:39:37 +0800
From: liulongfang <liulongfang@...wei.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>, "Alex
Williamson" <alex.williamson@...hat.com>
CC: "jgg@...dia.com" <jgg@...dia.com>, Jonathan Cameron
<jonathan.cameron@...wei.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linuxarm@...neuler.org" <linuxarm@...neuler.org>
Subject: Re: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
migration driver
On 2024/11/4 16:56, Shameerali Kolothum Thodi wrote:
>
>
>> -----Original Message-----
>> From: liulongfang <liulongfang@...wei.com>
>> Sent: Monday, November 4, 2024 8:31 AM
>> To: Alex Williamson <alex.williamson@...hat.com>
>> Cc: jgg@...dia.com; Shameerali Kolothum Thodi
>> <shameerali.kolothum.thodi@...wei.com>; Jonathan Cameron
>> <jonathan.cameron@...wei.com>; kvm@...r.kernel.org; linux-
>> kernel@...r.kernel.org; linuxarm@...neuler.org
>> Subject: Re: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
>> migration driver
> [...]
>
>>>>> +
>>>>> + seq_printf(seq,
>>>>> + "acc device:\n"
>>>>> + "guest driver load: %u\n"
>>>>> + "device opened: %d\n"
>>>>> + "migrate data length: %lu\n",
>>>>> + hisi_acc_vdev->vf_qm_state,
>>>>> + hisi_acc_vdev->dev_opened,
>>>>> + debug_migf->total_length);
>>>>
>>>> This debugfs entry is described as returning the data from the last
>>>> migration, but vf_qm_state and dev_opened are relative to the current
>>>> device/guest driver state. Both seem to have no relevance to the data
>>>> in debug_migf.
>>>>
>>>
>>> The benefit of dev_opened retention is that user can obtain the device
>> status
>>> during the cat migf_data operation.
>>>
>>
>> I will remove dev_opened in the next version.
>> And hisi_acc_vdev->vf_qm_state is changed to debug_migf-
>>> vf_data.vf_qm_state
>> Keep information about whether the device driver in the Guest OS is loaded
>> when live migration occurs.
>
> I think you already get that when you dump debug_migf->vf_data.
> So not required.
>
OK, vf_qm_state still needs to be deleted.
Thanks,
Longfang.
> Thanks,
> Shameer
>
> .
>
Powered by blists - more mailing lists