linux-kernel - Re: [PATCH v5 6/7] pinctrl: s32cc: add driver for GPIO functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73d0eddd-f36d-4bcb-ae23-e0f21c3eb178@oss.nxp.com>
Date: Mon, 4 Nov 2024 13:45:58 +0200
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: Markus Elfring <Markus.Elfring@....de>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, s32@....com, Bartosz Golaszewski
 <brgl@...ev.pl>, Chester Lin <chester62515@...il.com>,
 Conor Dooley <conor+dt@...nel.org>, Dong Aisheng <aisheng.dong@....com>,
 Fabio Estevam <festevam@...il.com>,
 Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jacky Bai
 <ping.bai@....com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Larisa Grigore <larisa.grigore@....com>, Lee Jones <lee@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Matthias Brugger <mbrugger@...e.com>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
 Alberto Ruiz <aruizrui@...hat.com>, Christophe Lizzi <clizzi@...hat.com>,
 Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH v5 6/7] pinctrl: s32cc: add driver for GPIO functionality

Hi Markus,

On 01/11/2024 17:45, Markus Elfring wrote:
>> Add basic GPIO functionality (request, free, get, set) for the existing
>> pinctrl SIUL2 driver since the hardware for pinctrl&GPIO is tightly
>> coupled.
> …
>> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> …
>> +static int s32_gpio_request(struct gpio_chip *gc, unsigned int gpio)
>> +{
> …
>> +	spin_lock_irqsave(&ipctl->gpio_configs_lock, flags);
>> +	list_add(&gpio_pin->list, &ipctl->gpio_configs);
>> +	spin_unlock_irqrestore(&ipctl->gpio_configs_lock, flags);
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&ipctl->gpio_configs_lock);”?

Thank you for the suggestion! I will fix it in v6.

Best regards,
Andrei

> https://elixir.bootlin.com/linux/v6.12-rc5/source/include/linux/spinlock.h#L551
> 
> Regards,
> Markus