[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f9fd6e53-ecae-4c7d-b35c-be0d27d81173@bjorling.me>
Date: Mon, 4 Nov 2024 14:24:25 +0100
From: Matias Bjørling <m@...rling.me>
To: Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>
Cc: dlemoal@...nel.org, cassel@...nel.org, linux-nvme@...ts.infradead.org,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
wangyugui@...-tech.com, martin.petersen@...cle.com, hare@...e.de,
Matias Bjørling <matias.bjorling@....com>
Subject: Re: [PATCH 1/3 v2] nvme: make independent ns identify default
>> FYI, I still disagree with this for the same reason as before.
>> Assuming we're not really going to see hard drivers I'd be fine
>> with using it by default for 2.0 (or better even 2.1) by default.
>
> I've got the rest of the required logs and identifications implemented
> in nvmet to support this. There's one more issue, though, if we do
> restrict the identify to >= 2.0 or 2.1. nvmet reports 1.3, and I suspect
> there's a bit more work than just changing the value of NVMET_DEFAULT_VS
> in order to comply with claiming that version.
>
Awesome. I'll hold off the implementation. Would you like me to take
your patches for a spin?
Powered by blists - more mailing lists