linux-kernel - Re: [PATCH] crypto: inside-secure - Fix the return value of safexcel_xcbcmac_cra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173082242323.5505.14169181853894683603@kwain>
Date: Tue, 05 Nov 2024 17:00:23 +0100
From: Antoine Tenart <atenart@...nel.org>
To: Li Huafei <lihuafei1@...wei.com>, davem@...emloft.net, herbert@...dor.apana.org.au, pliem@...linear.com
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, lihuafei1@...wei.com
Subject: Re: [PATCH] crypto: inside-secure - Fix the return value of safexcel_xcbcmac_cra_init()

Quoting Li Huafei (2024-10-31 12:27:55)
> The commit 320406cb60b6 ("crypto: inside-secure - Replace generic aes
> with libaes") replaced crypto_alloc_cipher() with kmalloc(), but did not
> modify the handling of the return value. When kmalloc() returns NULL,
> PTR_ERR_OR_ZERO(NULL) returns 0, but in fact, the memory allocation has
> failed, and -ENOMEM should be returned.
> 
> Fixes: 320406cb60b6 ("crypto: inside-secure - Replace generic aes with libaes")
> Signed-off-by: Li Huafei <lihuafei1@...wei.com>

Acked-by: Antoine Tenart <atenart@...nel.org>

Thanks!

> ---
>  drivers/crypto/inside-secure/safexcel_hash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c
> index e17577b785c3..f44c08f5f5ec 100644
> --- a/drivers/crypto/inside-secure/safexcel_hash.c
> +++ b/drivers/crypto/inside-secure/safexcel_hash.c
> @@ -2093,7 +2093,7 @@ static int safexcel_xcbcmac_cra_init(struct crypto_tfm *tfm)
>  
>         safexcel_ahash_cra_init(tfm);
>         ctx->aes = kmalloc(sizeof(*ctx->aes), GFP_KERNEL);
> -       return PTR_ERR_OR_ZERO(ctx->aes);
> +       return ctx->aes == NULL ? -ENOMEM : 0;
>  }
>  
>  static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm)
> -- 
> 2.25.1
>